refactor: optimize filterOptions to reduce allocations#4205
Open
TrevorBurnham wants to merge 1 commit intocloudscape-design:mainfrom
Open
refactor: optimize filterOptions to reduce allocations#4205TrevorBurnham wants to merge 1 commit intocloudscape-design:mainfrom
TrevorBurnham wants to merge 1 commit intocloudscape-design:mainfrom
Conversation
- Move searchableTagFields arrays to module scope to avoid creating new arrays on every matchesSingleOption call - Move toLowerCase() outside the filter loop so it's called once per filter operation instead of once per option Benchmarks show ~29% overall improvement, with up to 2x speedup for larger option lists (200+ items).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR optimizes the
filterOptionsutility used by Select, Multiselect, Autosuggest, and other dropdown components to improve filtering performance.Changes
Pre-allocate searchableTagFields arrays - Moved the
searchableTagFieldsarrays (['tags']and['tags', 'filteringTags']) to module scope instead of creating new arrays on everymatchesSingleOptioncall.Hoist toLowerCase() outside the loop - The search text normalization is now done once per filter operation instead of once per option.
Performance Impact
Micro-benchmarks show:
Related Components
This optimization benefits all components that use dropdown filtering:
How has this been tested?
Existing tests provide extensive coverage for this functionality.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.